-
Notifications
You must be signed in to change notification settings - Fork 4
chore(e2e): resolved fixme tests (#DS-4587) #1260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Visit the preview URL for this PR (updated for commit ce0b1c9): https://koobiq-next--prs-1260-9fo33ri4.web.app (expires Mon, 19 Jan 2026 09:39:55 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
|
/approve-snapshots |
|
🔄 Updating snapshots. |
1fa2bda to
5d6c495
Compare
4af9040 to
8803cd9
Compare
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR resolves FIXME tests by enabling previously skipped test suites in e2e Playwright tests. The changes convert test.fixme() to test.describe() for three component test suites and add corresponding screenshot baseline files.
Changes:
- Enabled test suites for table, progress-spinner, and input components by replacing
test.fixme()withtest.describe() - Added screenshot baseline files for the newly enabled tests (both light and dark themes)
Reviewed changes
Copilot reviewed 3 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/components/table/e2e.playwright-spec.ts | Changed test.fixme to test.describe for E2eTableStates test suite |
| packages/components/progress-spinner/e2e.playwright-spec.ts | Changed test.fixme to test.describe for E2eProgressSpinnerStates test suite |
| packages/components/input/e2e.playwright-spec.ts | Changed test.fixme to test.describe for E2eInputStateAndStyle test suite |
| packages/components/table/screenshots/*.png | Added screenshot baselines for table component tests |
| packages/components/progress-spinner/screenshots/*.png | Added screenshot baseline for progress-spinner component test |
| packages/components/input/screenshots/*.png | Added screenshot baselines for input component tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.