Skip to content

Conversation

@artembelik
Copy link
Contributor

No description provided.

@artembelik artembelik self-assigned this Dec 30, 2025
@artembelik artembelik added the bug Something isn't working label Dec 30, 2025
@github-actions
Copy link

github-actions bot commented Dec 30, 2025

Visit the preview URL for this PR (updated for commit ce0b1c9):

https://koobiq-next--prs-1260-9fo33ri4.web.app

(expires Mon, 19 Jan 2026 09:39:55 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@artembelik
Copy link
Contributor Author

/approve-snapshots

@github-actions
Copy link

🔄 Updating snapshots.

@github-actions
Copy link

🚨 E2E tests failed

Review the report for details.


💡 Comment /approve-snapshots to approve snapshot changes.

@artembelik
Copy link
Contributor Author

/approve-snapshots

@github-actions
Copy link

🔄 Updating snapshots.

@github-actions
Copy link

✅ Snapshots updated!

@artembelik artembelik changed the title fix: e2e magic pixels (#DS-4587) chore(e2e): resolved fixme tests (#DS-4587) Jan 14, 2026
@artembelik artembelik removed the bug Something isn't working label Jan 14, 2026
@artembelik artembelik marked this pull request as ready for review January 14, 2026 09:45
Copilot AI review requested due to automatic review settings January 14, 2026 09:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR resolves FIXME tests by enabling previously skipped test suites in e2e Playwright tests. The changes convert test.fixme() to test.describe() for three component test suites and add corresponding screenshot baseline files.

Changes:

  • Enabled test suites for table, progress-spinner, and input components by replacing test.fixme() with test.describe()
  • Added screenshot baseline files for the newly enabled tests (both light and dark themes)

Reviewed changes

Copilot reviewed 3 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/components/table/e2e.playwright-spec.ts Changed test.fixme to test.describe for E2eTableStates test suite
packages/components/progress-spinner/e2e.playwright-spec.ts Changed test.fixme to test.describe for E2eProgressSpinnerStates test suite
packages/components/input/e2e.playwright-spec.ts Changed test.fixme to test.describe for E2eInputStateAndStyle test suite
packages/components/table/screenshots/*.png Added screenshot baselines for table component tests
packages/components/progress-spinner/screenshots/*.png Added screenshot baseline for progress-spinner component test
packages/components/input/screenshots/*.png Added screenshot baselines for input component tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@artembelik artembelik merged commit 04d76cc into main Jan 14, 2026
14 checks passed
@artembelik artembelik deleted the fix/DS-4587 branch January 14, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants