Skip to content

feat(file-upload): redesign (#DS-3858) #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
NikGurev wants to merge 39 commits into
base: main
Choose a base branch
from
Open

feat(file-upload): redesign (#DS-3858) #1210

NikGurev wants to merge 39 commits into from

Conversation

@NikGurev
Copy link
Contributor

@NikGurev NikGurev commented Dec 17, 2025 •
edited
Loading

Summary

The pull request affects the redesign of the file-upload component.

  • Some design tokens (CSS variables) were removed
  • New CSS variables were added
  • Spacing and sizes were updated
  • Icons were updated to match the design
  • CSS class names were renamed to be more logical
  • Mixins were moved into the files corresponding to their components
Press for description in ru-RU

Пулл-реквест затрагивает редизайн компонента file-upload.

  • Удалены некоторые дизайн-токены (css-переменные)
  • Добавлены новые css-переменные
  • Обновлены отступы и размеры
  • Обновлены иконки в соотвествии с дизайном
  • Переименованы CSS-классы на более логичные
  • Вынесены миксины в соответствующие компонентам файлы

@NikGurev NikGurev requested a review from rmnturov December 17, 2025 17:52
@NikGurev NikGurev self-assigned this Dec 17, 2025
@NikGurev NikGurev added the enhancement New feature or request label Dec 17, 2025
@github-actions
Copy link

github-actions bot commented Dec 17, 2025

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

Base automatically changed from feat/DS-3748 to main December 18, 2025 12:22
@github-actions
Copy link

github-actions bot commented Dec 18, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit 8b61594):

https://koobiq-next--prs-1210-x94wd6uz.web.app

(expires Wed, 21 Jan 2026 19:35:07 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

@rmnturov
Copy link
Contributor

rmnturov commented Dec 19, 2025

Иконка черная должна быть. Также отступы неверные. В доках текст в компоненте должен быть на одном языке, выбранном
изображение

@rmnturov
Copy link
Contributor

rmnturov commented Dec 19, 2025

изображение

@rmnturov
Copy link
Contributor

rmnturov commented Dec 19, 2025

На крестик в строке давай состояния сделаем (ховер, эктив). В общем как у серой иконки-кнопки

@rmnturov
Copy link
Contributor

rmnturov commented Dec 19, 2025

Никита, я в макетах исправил неактивное состояние элемента списка. Подпись размера файла сделал цветом states-foreground-disabled
изображение

@NikGurev NikGurev mentioned this pull request Dec 19, 2025
Merged
@github-actions
Copy link

github-actions bot commented Dec 19, 2025

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

@github-actions
Copy link

github-actions bot commented Jan 12, 2026

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

@NikGurev NikGurev requested a review from artembelik January 12, 2026 14:32
@NikGurev NikGurev marked this pull request as ready for review January 12, 2026 14:32
@NikGurev NikGurev requested a review from lskramarov as a code owner January 12, 2026 14:33
@github-actions
Copy link

github-actions bot commented Jan 12, 2026

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

@github-actions
Copy link

github-actions bot commented Jan 12, 2026

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

@github-actions
Copy link

github-actions bot commented Jan 12, 2026

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

@github-actions
Copy link

github-actions bot commented Jan 12, 2026

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

@github-actions
Copy link

github-actions bot commented Jan 13, 2026

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

@github-actions
Copy link

github-actions bot commented Jan 13, 2026

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

@NikGurev
Copy link
Contributor Author

NikGurev commented Jan 13, 2026

/approve-snapshots

@github-actions
Copy link

github-actions bot commented Jan 13, 2026

🔄 Updating snapshots.

@github-actions
Copy link

github-actions bot commented Jan 13, 2026

✅ Snapshots updated!

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

@NikGurev
Copy link
Contributor Author

NikGurev commented Jan 16, 2026

/approve-snapshots

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

🔄 Updating snapshots.

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

🚨 Failed to update snapshots.

@NikGurev
Copy link
Contributor Author

NikGurev commented Jan 16, 2026

/approve-snapshots

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

🔄 Updating snapshots.

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

✅ Snapshots updated!

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

@NikGurev
Copy link
Contributor Author

NikGurev commented Jan 16, 2026

/approve-snapshots

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

🔄 Updating snapshots.

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

✅ Snapshots updated!

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

@NikGurev
Copy link
Contributor Author

NikGurev commented Jan 16, 2026

/approve-snapshots

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

🔄 Updating snapshots.

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

✅ Snapshots updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lskramarov lskramarov lskramarov approved these changes

@artembelik artembelik artembelik approved these changes

@rmnturov rmnturov rmnturov approved these changes

Assignees

@NikGurev NikGurev

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@NikGurev @rmnturov @lskramarov @artembelik