Skip to content

fix: validate spork signer before processing#2

Closed
thepastaclaw wants to merge 1 commit intoknst:refactor-spork-net-processing-v2from
thepastaclaw:fix-pr7303-spork-self-validate
Closed

fix: validate spork signer before processing#2
thepastaclaw wants to merge 1 commit intoknst:refactor-spork-net-processing-v2from
thepastaclaw:fix-pr7303-spork-self-validate

Conversation

@thepastaclaw
Copy link
Copy Markdown

Summary

  • Make CSporkManager::ProcessSpork() self-validate before mutating spork state
  • Replace the optional signer assert()/.value() path with guarded optional handling

Validation

  • git diff --check
  • Confirmed no remaining GetSignerKeyID().value() / direct assert pattern in the touched spork path
  • src/test/test_dash --run_test=spork_tests could not be run in this worktree because no test binary is present

Context: follow-up for CodeRabbit feedback on dashpay#7303.

@thepastaclaw
Copy link
Copy Markdown
Author

Closing this follow-up because CodeRabbit withdrew the signer-assert concern as an intentional post-validation contract. I’ll replace it with the requested mainnet P2P spork follow-up instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant