Fix Parser instantiation and globals in ComponentProvider

.changeset/fix-component-provider-parser-globals.md

@@ -0,0 +1,10 @@
+---
+"@tko/provider.component": patch
+---
+
+Fix component params globals resolution in `ComponentProvider`.
+
+`getComponentParams` now instantiates `Parser` with `new Parser()` and passes
+provider globals to `parser.parse(...)`, matching canonical parser usage in
+other providers. This restores resolution of globals in component `params`
+expressions (for example, `params="answer: GLOBAL_CONST"`).

packages/provider.component/spec/componentProviderBehaviors.ts

@@ -150,6 +150,29 @@ describe('Components: Provider', function () {
       applyBindings({}, ne)
       // No error raised.
     })
+
+    it('resolves globals in component params', function () {
+      const provider = new MultiProvider({
+        providers: [new DataBindProvider(), new ComponentProvider()],
+        globals: { GLOBAL_CONST: 42 }
+      })
+      options.bindingProviderInstance = provider
+      bindingHandlers = provider.bindingHandlers
+      bindingHandlers.set(componentBindings)
+      bindingHandlers.set(coreBindings)
+
+      components.register('xenon', {
+        viewModel: function (params) {
+          expect(params.answer).to.equal(42)
+        },
+        template: '<span>ok</span>',
+        synchronous: true,
+        ignoreCustomElementWarning: true
+      })
+      const xe = document.createElement('xenon')
+      xe.setAttribute('params', 'answer: GLOBAL_CONST')
+      applyBindings({}, xe)
+    })
   })
 
   /* describe("nodeParamsToObject", function() {

packages/provider.component/src/ComponentProvider.ts

@@ -72,9 +72,9 @@ export default class ComponentProvider extends Provider {
       return { $raw: {} }
     }
 
-    const parser = new (Parser as any)(node, context, this.globals) as Parser
+    const parser = new Parser()
     const paramsString = (node.getAttribute('params') || '').trim()
-    const accessors = parser.parse(paramsString, context, undefined, node)
+    const accessors = parser.parse(paramsString, context, this.globals, node)
     if (!accessors || Object.keys(accessors).length === 0) {
       return { $raw: {} }
     }

packages/utils.parser/src/Parser.ts

@@ -32,11 +32,7 @@ type InnerFilterType = (value: any, ignored: any, context: any, globals: any, no
 type FilterType = InnerFilterType & { precedence: number }
 
 /**
- * Construct a new Parser instance with new Parser(node, context)
- * @param {Node} node    The DOM element from which we parsed the
- *                         content.
- * @param {object} context The Knockout context.
- * @param {object} globals An object containing any desired globals.
+ * Parser for binding and params expressions.
  */
 export default class Parser {
   ch: any