Fix linting errors and warnings #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove async keyword from functions that don't use async features - Fix TRY401 issues by removing redundant exception objects from logging.exception calls - Add keyword-only parameters for boolean arguments to fix FBT001 issues - Remove unused variable in exception handler - Update validation runner to handle both sync and async functions
This was referenced Oct 29, 2025
This was referenced Nov 8, 2025
Copilot AI
added a commit
that referenced
this pull request
Nov 12, 2025
…dling Fixes from Claude's code review: 1. Fixed deleted files path conversion (Issue #1 - CRITICAL) - Convert relative paths from manifest to absolute paths for cleanup - Check if project_root is set before conversion - Prevents silent failures in deleted file cleanup 2. Fixed async lock initialization (Issue #2) - Initialize _manifest_lock as None in __init__ (sync context) - Lazily create lock in async methods (_index_file, _delete_file) - Prevents potential RuntimeError in certain execution contexts 3. Null checks already in place (Issue #3) - All manifest operations already check for lock existence - No changes needed All 36 tests passing. Co-authored-by: bashandbone <89049923+bashandbone@users.noreply.github.com>
This was referenced Nov 19, 2025
5 tasks
This was referenced Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses multiple linting errors and warnings identified in the codebase:
Changes Made
Async Function Cleanup (RUF029)
asynckeyword from functions that don't use async features:validate_core_protocols()invalidation/validation_demo.pyvalidate_source_factory()invalidation/validation_demo.pyvalidate_configuration_system()invalidation/validation_demo.pyvalidate_backward_compatibility()invalidation/validation_demo.pymigrate_config_to_extensible()insrc/codeweaver/server.pyLogging Exception Handling (TRY401)
logging.exceptioncalls:src/codeweaver/sources/integration.pylines 102 and 157logging.exceptionautomatically includes exception infoBoolean Parameter Handling (FBT001)
migrate_config_to_extensible():enable_pluginsparameterServerMigrationManager.perform_migration():backup_componentsparameterCode Quality Improvements
ein exception handler (F841)inspect.iscoroutinefunction()Files Modified
src/codeweaver/server.pysrc/codeweaver/sources/integration.pyvalidation/validation_demo.pyAll changes maintain backward compatibility while improving code quality and following Python best practices.
💻 View my work • 🚫 Ban all checks • 👤 Initiated by @bashandbone • About Codegen