Skip to content

AP-24593, AP-25234: update scripting editor #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chaubold merged 2 commits into from
Dec 19, 2025
+14 −9
Merged

AP-24593, AP-25234: update scripting editor #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27cce0c
AP-25234, AP-24593: Update @knime/scripting-editor to 0.0.119
HedgehogCode Dec 19, 2025
434bd61
AP-25234: Adapt to settings API changes
HedgehogCode Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions org.knime.python3.scripting.nodes/js-src/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion org.knime.python3.scripting.nodes/js-src/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
},
"dependencies": {
"@knime/components": "1.43.0",
"@knime/scripting-editor": "0.0.118",
"@knime/scripting-editor": "0.0.119",
"@knime/styles": "1.8.0",
"@knime/ui-extension-service": "2.6.0",
"@vueuse/core": "13.8.0",
Expand Down
4 changes: 3 additions & 1 deletion org.knime.python3.scripting.nodes/js-src/src/__mocks__/browser-mock-services.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ export default {
getLanguageServerConfig: () => Promise.resolve(JSON.stringify({})),
},
}),
settingsService: createSettingsServiceMock(DEFAULT_INITIAL_SETTINGS),
settingsService: createSettingsServiceMock({
settings: DEFAULT_INITIAL_SETTINGS,
}),
initialData: DEFAULT_INITIAL_DATA,
displayMode: "large",
} satisfies InitMockData;
3 changes: 2 additions & 1 deletion org.knime.python3.scripting.nodes/js-src/src/__mocks__/mock-data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,4 +122,5 @@ export const DEFAULT_INITIAL_DATA: PythonInitialData = {

export const createPythonSettingsServiceMock = (
settings?: PythonScriptingNodeSettings,
) => createSettingsServiceMock(settings ?? DEFAULT_INITIAL_SETTINGS);
) =>
createSettingsServiceMock({ settings: settings ?? DEFAULT_INITIAL_SETTINGS });
2 changes: 1 addition & 1 deletion org.knime.python3.scripting.nodes/js-src/src/components/EnvironmentSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ onMounted(() => {
const executableSettingState = useExecutableSettingStore();
if (executableSettingState.value === null) {
const register = getSettingsService().registerSettings("model");
const environmentSettingState = register("");
const environmentSettingState = register({ initialValue: "" });
if (executableSelection.id === "") {
executableSettingState.value =
environmentSettingState.addControllingFlowVariable(null);
Expand Down
2 changes: 1 addition & 1 deletion org.knime.python3.scripting.nodes/js-src/src/python-scripting-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export const pythonScriptingService = {
initExecutableSelection: (): void => {
const settings = getSettingsService().getSettings();

setSelectedExecutable({ id: settings.executableSelection ?? "" });
setSelectedExecutable({ id: settings?.executableSelection ?? "" });
pythonScriptingService.updateExecutableSelection(executableSelection.id);
const executableInfo = getPythonInitialData().executableOptionsList.find(
({ id }) => id === executableSelection.id,
Expand Down
2 changes: 2 additions & 0 deletions org.knime.python3.scripting.nodes/js-src/src/test-setup/setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ vi.mock("@knime/ui-extension-service", () => ({}));
initMocked({
scriptingService: {
sendToService: vi.fn(),
callRpcMethod: vi.fn(),
getOutputPreviewTableInitialData: vi.fn(() => Promise.resolve(undefined)),
registerEventHandler: vi.fn(),
// @ts-expect-error Mock doesn't fully implement MonacoLSPConnection interface
Expand All @@ -37,6 +38,7 @@ initMocked({
},
settingsService: {
getSettings: vi.fn(() => Promise.resolve(DEFAULT_INITIAL_SETTINGS)),
getSettingsInitialData: vi.fn(),
registerSettingsGetterForApply: vi.fn(),
// @ts-expect-error Mock doesn't fully implement SettingState interface
registerSettings: vi.fn(() =>
Expand Down