Skip to content

cleanup: replace docker.io image references with ghcr.io mirrors#3775

Open
Ankitsinghsisodya wants to merge 1 commit into
knative:mainfrom
Ankitsinghsisodya:cleanup/remove-docker-io-2720
Open

cleanup: replace docker.io image references with ghcr.io mirrors#3775
Ankitsinghsisodya wants to merge 1 commit into
knative:mainfrom
Ankitsinghsisodya:cleanup/remove-docker-io-2720

Conversation

@Ankitsinghsisodya
Copy link
Copy Markdown
Contributor

Closes #2720

Summary

  • Replace docker://docker.io/paketocommunity/rust:0.65.0 with docker://ghcr.io/paketocommunity/rust:0.65.0 in addRustBuildpack
  • Update the HasPrefix check in updateJavaBuildpacks from docker://docker.io/paketobuildpacks/ to docker://ghcr.io/paketobuildpacks/ to match the upstream builder config which has already migrated to ghcr
  • Replace docker://index.docker.io/paketobuildpacks/quarkus: with docker://ghcr.io/paketobuildpacks/quarkus: in addQuarkusBuildpack

Motivation

Hard-coding docker.io URIs exposes CI and builds to Docker Hub rate limits and creates a dependency on an external registry the project does not control. The project already uses ghcr.io for its own images. This change consolidates on ghcr.io for paketo buildpack references in the builder update tooling.

Notes

pkg/oci/python_builder.go uses python:3.13-slim which still implicitly resolves to docker.io since there is no ghcr.io mirror for the official Python base image. Addressing that is left as a separate maintainer decision per the issue thread.

- Changed buildpack URIs from Docker Hub to GitHub Container Registry for Rust and Quarkus buildpacks.
- Updated logic in updateJavaBuildpacks to reflect the new registry for Java buildpacks, ensuring consistency across the configuration.
Copilot AI review requested due to automatic review settings May 17, 2026 09:45
@knative-prow knative-prow Bot requested review from dsimansk and jrangelramos May 17, 2026 09:45
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 17, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Ankitsinghsisodya
Once this PR has been reviewed and has the lgtm label, please assign jrangelramos for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the size/XS 🤖 PR changes 0-9 lines, ignoring generated files. label May 17, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 17, 2026

Hi @Ankitsinghsisodya. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow Bot added the needs-ok-to-test 🤖 Needs an org member to approve testing label May 17, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.91%. Comparing base (584c11e) to head (180c0b3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3775      +/-   ##
==========================================
- Coverage   57.03%   56.91%   -0.12%     
==========================================
  Files         182      182              
  Lines       21376    21376              
==========================================
- Hits        12191    12166      -25     
- Misses       7953     7981      +28     
+ Partials     1232     1229       -3     
Flag Coverage Δ
e2e 35.81% <ø> (ø)
e2e go 31.41% <ø> (ø)
e2e node 27.25% <ø> (ø)
e2e python 31.78% <ø> (ø)
e2e quarkus 27.37% <ø> (ø)
e2e rust 26.78% <ø> (+0.01%) ⬆️
e2e springboot 25.31% <ø> (ø)
e2e typescript 27.35% <ø> (ø)
e2e-config-ci ?
integration 17.20% <ø> (+0.03%) ⬆️
unit macos-14 45.09% <ø> (ø)
unit macos-latest 45.09% <ø> (ø)
unit ubuntu-24.04-arm 45.33% <ø> (ø)
unit ubuntu-latest 46.04% <ø> (ø)
unit windows-latest 45.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lkingland
Copy link
Copy Markdown
Member

/ok-to-test

@knative-prow knative-prow Bot added ok-to-test 🤖 Non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test 🤖 Needs an org member to approve testing labels May 18, 2026
@Ankitsinghsisodya
Copy link
Copy Markdown
Contributor Author

/ok-to-test

Can plz you re run the failed CI sir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test 🤖 Non-member PR verified by an org member that is safe to test. size/XS 🤖 PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cleanup: Further remove docker.io registry

2 participants