cleanup: replace docker.io image references with ghcr.io mirrors#3775
cleanup: replace docker.io image references with ghcr.io mirrors#3775Ankitsinghsisodya wants to merge 1 commit into
Conversation
- Changed buildpack URIs from Docker Hub to GitHub Container Registry for Rust and Quarkus buildpacks. - Updated logic in updateJavaBuildpacks to reflect the new registry for Java buildpacks, ensuring consistency across the configuration.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ankitsinghsisodya The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Ankitsinghsisodya. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3775 +/- ##
==========================================
- Coverage 57.03% 56.91% -0.12%
==========================================
Files 182 182
Lines 21376 21376
==========================================
- Hits 12191 12166 -25
- Misses 7953 7981 +28
+ Partials 1232 1229 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/ok-to-test |
Can plz you re run the failed CI sir! |
Closes #2720
Summary
docker://docker.io/paketocommunity/rust:0.65.0withdocker://ghcr.io/paketocommunity/rust:0.65.0inaddRustBuildpackHasPrefixcheck inupdateJavaBuildpacksfromdocker://docker.io/paketobuildpacks/todocker://ghcr.io/paketobuildpacks/to match the upstream builder config which has already migrated to ghcrdocker://index.docker.io/paketobuildpacks/quarkus:withdocker://ghcr.io/paketobuildpacks/quarkus:inaddQuarkusBuildpackMotivation
Hard-coding docker.io URIs exposes CI and builds to Docker Hub rate limits and creates a dependency on an external registry the project does not control. The project already uses ghcr.io for its own images. This change consolidates on ghcr.io for paketo buildpack references in the builder update tooling.
Notes
pkg/oci/python_builder.gousespython:3.13-slimwhich still implicitly resolves to docker.io since there is no ghcr.io mirror for the official Python base image. Addressing that is left as a separate maintainer decision per the issue thread.