Skip to content

fix: use non-root group for dialer and volume-uploader pods #3767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Itx-Psycho0 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use non-root group for dialer and volume-uploader pods #3767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions pkg/k8s/security_context.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,6 @@ import (
// SeccompProfile is set at both pod and container level (see defaultSecurityContext)
// as defence-in-depth: pod-level covers all containers by default, container-level
// ensures compliance even if a pod-level context is ever overridden downstream.
//
// RunAsGroup: 0 (root group) is retained on non-OpenShift to preserve compatibility
// with Tekton buildpack tasks that mount volumes with group ownership 0.
// This does not violate the restricted profile (which checks UID, not GID) but is
// tracked for remediation in https://github.com/knative/func/issues/3517.
func defaultPodSecurityContext() *corev1.PodSecurityContext {
runAsNonRoot := true
seccompProfile := &corev1.SeccompProfile{Type: corev1.SeccompProfileTypeRuntimeDefault}
Expand All @@ -31,8 +26,8 @@ func defaultPodSecurityContext() *corev1.PodSecurityContext {
}

runAsUser := int64(1001)
runAsGroup := int64(0) // Match Tekton buildpack task group; see doc comment above.
fsGroup := int64(1002) // Keep FSGroup for volume ownership
runAsGroup := int64(1001) // Use non-root group for better security
fsGroup := int64(1002) // Keep FSGroup for volume ownership
return &corev1.PodSecurityContext{
RunAsNonRoot: &runAsNonRoot,
SeccompProfile: seccompProfile,
Expand Down
Loading