Feature+Test: Add runtime-aware builder config and Config CI e2e tests.#3479
Conversation
|
@twoGiants: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
knative-prow
bot
added
do-not-merge/work-in-progress
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3479 +/- ##
==========================================
+ Coverage 54.79% 55.05% +0.26%
==========================================
Files 181 181
Lines 20443 20476 +33
==========================================
+ Hits 11202 11274 +72
+ Misses 8064 8009 -55
- Partials 1177 1193 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
twoGiants
changed the title
knative-prow
bot
removed
the
do-not-merge/work-in-progress
twoGiants
changed the title
|
/kind enhancement /cc @gauron99 @creydr @lkingland The e2e test are done with a few other features and refactorings. Check out the PR description for details. Thank you for the review 😸 👍 . |
knative-prow
bot
added
the
kind/enhancement
twoGiants
force-pushed
the
issue-783-e2e-tests-with-act
branch
4 times, most recently
from
31a683b to
3d93b57
Compare
|
/retest |
twoGiants
force-pushed
the
issue-783-e2e-tests-with-act
branch
from
3d93b57 to
92330f9
Compare
gauron99
left a comment
gauron99
left a comment
There was a problem hiding this comment.
Cool changes! thanks a lot for the improvements to user FUNC_ env vars instead of the flags. Thanks! Got one question about builder determination and one small note about the other changes 😄 .
gauron99
left a comment
gauron99
left a comment
There was a problem hiding this comment.
/lgtm
/hold unhold when you please
knative-prow
bot
added
the
do-not-merge/hold
Generated GitHub Actions workflows from `func config ci` previously used CLI flags for deploy configuration and had no builder selection logic. The deploy step now uses environment variables (FUNC_BUILDER, FUNC_REGISTRY, FUNC_REMOTE, FUNC_VERBOSE) and selects the builder based on the function runtime: host for Go/Python local builds, pack for Node/TypeScript/Rust/Quarkus/Springboot, and s2i for Python remote builds. CIConfig loads the function upfront, encapsulating runtime and root path, removing the need for callers to load separately. Platform validation now rejects empty values and error messages include supported platforms. Adds e2e tests using nektos/act to run generated workflows against a real cluster for each supported runtime, with a corresponding GitHub Actions job, Makefile target, and hack/test-full.sh entry. act is installed via hack/binaries.sh. Fixes typos in CI workflow comments (Cluser → Cluster, runtim → runtime). Adds missing .PHONY declarations. Issue knative#3256 Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>
twoGiants
force-pushed
the
issue-783-e2e-tests-with-act
branch
from
266830b to
675cd38
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, twoGiants The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
|
All looks good to me! feel free to unhold whenever you please. @twoGiants |
|
/unhold |
knative-prow
bot
removed
the
do-not-merge/hold
2 participants
Changes
func config cinow setsFUNC_BUILDERbased on the function runtime (host for Go/Python local, pack for Node/TypeScript/Rust/Quarkus/Springboot, s2i for Python remote) and uses environment variables (FUNC_BUILDER,FUNC_REGISTRY,FUNC_REMOTE,FUNC_VERBOSE) instead of CLI flagstest-e2e-config-ciGitHub Actions job, Makefile target, andhack/test-full.shentryactbinary viahack/binaries.sh.PHONYdeclarations fortest-e2e-matrixandtest-full-loggedCluser→Cluster,runtim→runtime)/kind enhancement
Relates to #3256
Release Note
Docs