Skip to content

Update default minimum TLS version to 1.3#8916

Open
Fedosin wants to merge 1 commit intoknative:mainfrom
Fedosin:tls-13
Open

Update default minimum TLS version to 1.3#8916
Fedosin wants to merge 1 commit intoknative:mainfrom
Fedosin:tls-13

Conversation

@Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Mar 17, 2026

Fixes #

Proposed Changes

This updates the eventingtls package to use TLS 1.3 as the default minimum version, aligning with the default behavior of knative.dev/pkg/network/tls. The fallback to TLS 1.2 and the associated TODO have been removed.

Additionally, tests asserting the default MinVersion have been removed from pkg/eventingtls and cmd/requestreply, as this configuration is now handled entirely by the underlying knative.dev/pkg/network/tls utility.
🧹

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note


Docs

@knative-prow
Copy link

knative-prow bot commented Mar 17, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Fedosin
Once this PR has been reviewed and has the lgtm label, please assign aliok for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 17, 2026
@knative-prow knative-prow bot requested review from Leo6Leo and matzew March 17, 2026 19:31
@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.02%. Comparing base (cb8edb9) to head (7da07cc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8916      +/-   ##
==========================================
- Coverage   51.02%   51.02%   -0.01%     
==========================================
  Files         409      409              
  Lines       22001    21999       -2     
==========================================
- Hits        11226    11224       -2     
  Misses       9911     9911              
  Partials      864      864              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This updates the eventingtls package to use TLS 1.3 as the default minimum
version, aligning with the default behavior of `knative.dev/pkg/network/tls`.
The fallback to TLS 1.2 and the associated TODO have been removed.

Additionally, tests asserting the default MinVersion have been removed
from `pkg/eventingtls` and `cmd/requestreply`, as this configuration is
now handled entirely by the underlying `knative.dev/pkg/network/tls` utility.

Signed-off-by: Mikhail Fedosin <mfedosin@redhat.com>
@knative-prow
Copy link

knative-prow bot commented Mar 19, 2026

@Fedosin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
conformance-tests_eventing_main 7da07cc link true /test conformance-tests
upgrade-tests_eventing_main 7da07cc link true /test upgrade-tests
reconciler-tests_eventing_main 7da07cc link true /test reconciler-tests

Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant