Update default minimum TLS version to 1.3#8916
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Fedosin The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8916 +/- ##
==========================================
- Coverage 51.02% 51.02% -0.01%
==========================================
Files 409 409
Lines 22001 21999 -2
==========================================
- Hits 11226 11224 -2
Misses 9911 9911
Partials 864 864 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This updates the eventingtls package to use TLS 1.3 as the default minimum version, aligning with the default behavior of `knative.dev/pkg/network/tls`. The fallback to TLS 1.2 and the associated TODO have been removed. Additionally, tests asserting the default MinVersion have been removed from `pkg/eventingtls` and `cmd/requestreply`, as this configuration is now handled entirely by the underlying `knative.dev/pkg/network/tls` utility. Signed-off-by: Mikhail Fedosin <mfedosin@redhat.com>
|
@Fedosin: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Fixes #
Proposed Changes
This updates the eventingtls package to use TLS 1.3 as the default minimum version, aligning with the default behavior of
knative.dev/pkg/network/tls. The fallback to TLS 1.2 and the associated TODO have been removed.Additionally, tests asserting the default MinVersion have been removed from
pkg/eventingtlsandcmd/requestreply, as this configuration is now handled entirely by the underlyingknative.dev/pkg/network/tlsutility.🧹
Pre-review Checklist
Release Note
Docs