asm_avr.inc: add missing memory clobber #238
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that older versions of GCC did not optimize memory accesses across function calls. That made function calls an implicit memory barrier, even when the function implementation was part of the current compilation unit and the compiler could infer that a function did not touch memory. With inline assembly, the compiler assumes the clobber list to be exhaustive. If no memory clobber is given and a function does not touch memory except for the inline assembly, the compiler may assume that a function does not change memory contents and optimize accordingly. Adding the required memory clobbers fixes incorrect computations of `vli_mmod_fast_secp256r1()` on AVR GCC 15.2.0.
Owner
|
I wonder if using dummy memory operands would be preferable (ie, provide more accurate constraints to the compiler). It looks like the syntax should be |
Author
|
Thx for the pointer, I'll give it a spin :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that older versions of GCC did not optimize memory accesses across function calls. That made function calls an implicit memory barrier, even when the function implementation was part of the current compilation unit and the compiler could infer that a function did not touch memory.
With inline assembly, the compiler assumes the clobber list to be exhaustive. If no memory clobber is given and a function does not touch memory except for the inline assembly, the compiler may assume that a function does not change memory contents and optimize accordingly.
Adding the required memory clobbers fixes incorrect computations of
vli_mmod_fast_secp256r1()on AVR GCC 15.2.0.Fixes #236