Apply exclusions config to entity inventory#1
Open
ctbjdm wants to merge 1 commit into
Open
Conversation
The script reads the `exclusions` config but never applies it. Domain, pattern, area, and entity exclusions are silently ignored, so the entity inventory always lists every entity regardless of config. Fix: filter `self.states` once after fetch, using the existing `_should_exclude_entity()` method. All downstream functions (`_count_entities_by_domain`, `generate_entity_inventory`, etc.) work on the filtered list automatically with no further changes. Adds an "Excluded N entities (X -> Y)" log line so you can see at runtime how many entities your config filtered out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script reads the
exclusionsconfig but never applies it. Domain, pattern, area, and entity exclusions are silently ignored, so the entity inventory always lists every entity regardless of config.Fix: filter
self.statesonce after fetch, using the existing_should_exclude_entity()method. All downstream functions (_count_entities_by_domain,generate_entity_inventory, etc.) work on the filtered list automatically with no further changes.Adds an "Excluded N entities (X -> Y)" log line so you can see at runtime how many entities your config filtered out.