Allow use of virtual python environments while maintaining system python support #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Alex, I think the only real change is introducing the PYDEV_USR_LDFLAGS. Could you compute that in the if/else statement instead of introducing the _RAW variable? Is it required to move CONFIG.PyDevice from TARGETS to CONFIGS? Also, please remove the commit for the CONFIG file as that is your site specific. You can put your site specific changes into the CONFIG_SITE.local which is not part of the repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes a user can now build PyDevice through a virtual python environment (with managers like pixi, conda), provided there is a "python-config" file within the environment packages.
Changes to the Makefile now read in either environment libraries or system libraries based on what is specified in the python-config path.