feat: add token source position tracking to lexer#27
Open
label-hook[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds source position tracking to sqlparse tokens by extending the token format from 2-tuples
(ttype, value)to 3-tuples(ttype, value, position)where position is a tuple of(start, end)character indices. This enables syntax highlighting and other position-aware use cases while maintaining backwards compatibility.Changes
sqlparse/lexer.py): Enhanced tokenization to track character positions and emit tokens with position informationsqlparse/filters/tokens.py): Modified filters to handle 3-tuple tokens while preserving existing functionalitysqlparse/engine/filter_stack.py): Updated to properly process position-aware token streamssqlparse/sql.py): Modified token processing to work with extended token formatThe implementation is designed to be minimally invasive - the main API surface area documented in the official docs remains unchanged. Only direct lexer usage is affected by the token format extension.
Testing
Closes #24
Closes #24