Skip to content

Clean up code #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkarbowiak merged 2 commits into from
Sep 23, 2025
Merged

Clean up code #152

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6acbde4
Cleanup: devirtualise destructor
kkarbowiak Sep 23, 2025
c2ba365
Cleanup: simplify assignment
kkarbowiak Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/argparse.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,7 +608,7 @@ namespace argparse
virtual auto get_nargs_option() const -> Nargs = 0;

protected:
virtual ~Formattable() = default;
~Formattable() = default;
};

struct Options
Expand Down Expand Up @@ -1298,7 +1298,7 @@ namespace argparse
{
auto const prefix = it->m_token.substr(0, pos);
auto const value = it->m_token.substr(pos);
*it = Token{prefix};
it->m_token = prefix;
return value;
}
}
Expand Down
Loading