Skip to content

Clean up code #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkarbowiak merged 3 commits into from
May 13, 2025
Merged

Clean up code #133

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8763f71
Cleanup: remove const qualifier
kkarbowiak May 13, 2025
3917f35
Cleanup: access static member statically
kkarbowiak May 13, 2025
52a3324
Cleanup: remove redundant member initialiser
kkarbowiak May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions include/argparse.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ namespace argparse
}

private:
std::any const m_value;
std::any m_value;
};

class Parameters
Expand Down Expand Up @@ -329,7 +329,7 @@ namespace argparse
private:
static auto extract_filename(std::string_view path) -> std::string_view
{
if (auto path_separator = path.find_last_of("/\\"); path_separator != path.npos)
if (auto path_separator = path.find_last_of("/\\"); path_separator != std::string_view::npos)
{
return path.substr(path_separator + 1);
}
Expand Down Expand Up @@ -1528,7 +1528,6 @@ namespace argparse
ArgumentBuilder(argument_uptrs & arguments, optstring & version, std::vector<std::string> names, MutuallyExclusiveGroup const * group = nullptr)
: m_arguments(arguments)
, m_version(version)
, m_options()
{
m_options.names = std::move(names);
m_options.mutually_exclusive_group = group;
Expand Down