Skip to content

Clean up code #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkarbowiak merged 3 commits into from
May 13, 2025
Merged

Clean up code #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f7c1d48
Cleanup: add const qualifiers
kkarbowiak May 13, 2025
9c226aa
Cleanup: add const qualifier
kkarbowiak May 13, 2025
8bc8ced
Cleanup: mark constructor as explicit
kkarbowiak May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions include/argparse.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,7 +777,7 @@ namespace argparse
return get_dest_name();
}

auto get_consumable(tokens & args)
auto get_consumable(tokens & args) const
{
return args
| std::views::drop_while([](auto const & token)
Expand Down Expand Up @@ -1099,7 +1099,7 @@ namespace argparse
return get_joined_names();
}

auto check_errors(std::string const & value, std::ranges::view auto args) -> void
auto check_errors(std::string const & value, std::ranges::view auto args) const -> void
{
switch (m_options.action)
{
Expand Down Expand Up @@ -1151,14 +1151,14 @@ namespace argparse
}
}

auto get_consumable(tokens & args)
auto get_consumable(tokens & args) const
{
return args
| std::views::drop_while([](auto const & token) { return token.m_consumed; })
| std::views::take_while([](auto const & token) { return token.m_token != "--"; });
}

auto get_consumable_args(auto it, std::ranges::view auto consumable)
auto get_consumable_args(auto it, std::ranges::view auto consumable) const
{
return std::ranges::subrange(std::next(it), consumable.end())
| std::views::take_while([](auto const & token) { return !token.m_token.starts_with("-"); });
Expand Down Expand Up @@ -1530,7 +1530,7 @@ namespace argparse
class ArgumentBuilder
{
public:
ArgumentBuilder(argument_uptrs & arguments, optstring & version, std::vector<std::string> names, MutuallyExclusiveGroup * group = nullptr)
ArgumentBuilder(argument_uptrs & arguments, optstring & version, std::vector<std::string> names, MutuallyExclusiveGroup const * group = nullptr)
: m_arguments(arguments)
, m_version(version)
, m_options()
Expand Down
2 changes: 1 addition & 1 deletion test/unittest/cstring_array.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
template<std::size_t N, class... Ts>
struct cstr_arr
{
cstr_arr(Ts... args)
explicit cstr_arr(Ts... args)
: array{args...}
{
}
Expand Down