Skip to content

Allow passing message tags in action(target, message, tags) #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaxLeiter wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow passing message tags in action(target, message, tags) #411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/clientapi.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,8 @@ Send a CTCP request to target with any number of parameters.
##### `.ctcpResponse(target, type [, paramN])`
Send a CTCP response to target with any number of parameters.

##### `.action(target, message)`
Send an action message (typically /me) to a target.
##### `.action(target, message [, tags])`
Send an action message (typically /me) to a target, optionally with tags.

##### `.whois(nick [, cb])`
Receive information about a user on the network if they exist. Optionally calls
Expand Down
11 changes: 9 additions & 2 deletions src/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,7 +662,7 @@ module.exports = class IrcClient extends EventEmitter {
);
}

action(target, message) {
action(target, message, tags) {
const that = this;

// Maximum length of target + message we can send to the IRC server is 500 characters
Expand All @@ -677,7 +677,14 @@ module.exports = class IrcClient extends EventEmitter {
const blocks = [...lineBreak(message, { bytes: blockLength, allowBreakingWords: true, allowBreakingGraphemes: true })];

blocks.forEach(function(block) {
that.ctcpRequest(target, commandName, block);
const ctcpBody = String.fromCharCode(1) + commandName + ' ' + block + String.fromCharCode(1);
if (tags && Object.keys(tags).length) {
const msg = new IrcMessage('PRIVMSG', target, ctcpBody);
msg.tags = tags;
that.raw(msg);
} else {
that.ctcpRequest(target, commandName, block);
}
});

return blocks;
Expand Down
Loading