Print "all requested tasks are running" message only once per ready transition#115
Merged
Print "all requested tasks are running" message only once per ready transition#115
Conversation
Co-authored-by: alexec <1142830+alexec@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update app to print ready message only once
Print "all requested tasks are running" message only once per ready transition
Mar 20, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines RunSubgraph logging so the “🔵 all requested tasks are running:” message is emitted only on a not-ready → ready transition, avoiding repeated output while tasks remain running.
Changes:
- Add an
allRunningstate flag in theRunSubgraphevent loop to gate ready-message printing to a single transition. - Reset
allRunningon certain events (poison pill with remaining tasks, and task-run events) so the message can print again after recovery. - Add tests asserting the ready message is printed once for a stable service and twice across a watched-file restart.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
internal/run.go |
Adds allRunning gating and reset logic for the ready message in the main event loop. |
internal/run_test.go |
Adds regression tests asserting ready-message print counts for stable and restart scenarios. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alexec
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ready message (
🔵 all requested tasks are running:) was printed on every poison pill event while tasks remained running, producing duplicate output. It should print once when the app flips to ready, and again only if it goes unready and recovers.Changes
internal/run.go: Introduce anallRunningbool flag scoped to the event loop. The message prints only whenallRunningtransitionsfalse → true. The flag resets tofalsein two places:remainingTasksis non-empty (a task is no longer complete)cancelled → waiting → runningfaster than the main loop drains the event channel, meaning intermediate non-running phases are never observed via poison pills aloneinternal/run_test.go: Two new test cases:📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.