Skip to content

125. Valid Palindrome#64

Open
kitano-kazuki wants to merge 1 commit into
mainfrom
125-valid-palindrome
Open

125. Valid Palindrome#64
kitano-kazuki wants to merge 1 commit into
mainfrom
125-valid-palindrome

Conversation

@kitano-kazuki
Copy link
Copy Markdown
Owner

Copy link
Copy Markdown

@naoto-iwase naoto-iwase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stepを経るごとに洗練されていき良いと思いました。

Comment thread memo.md
Comment on lines +26 to +27
if not s:
return True
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここを書かなくてもwhileがskipされてTrueが返りますが、あってもいいとも思います。

Comment thread memo.md
Comment on lines +107 to +110
if alphanumerics == list(reversed(alphanumerics)):
return True
else:
return False
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return alphanumerics == list(reversed(alphanumerics)) で良い気がします。

あと、list(reversed(alphanumerics)) は alphanumerics[::-1] と書くこともできますね。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants