50 pow x n#46
Open
kitano-kazuki wants to merge 9 commits into
Open
Conversation
Yuto729
reviewed
May 10, 2026
| x = 1 / x | ||
| n *= -1 | ||
|
|
||
| multiplier = 1 |
There was a problem hiding this comment.
余分にかけたxはまとめて反映していると思いますが、multiplierだとその意図がやや伝わりにくい気がします
remaining_productとかextra_factorなどはどうでしょうか
5103246
reviewed
May 17, 2026
Comment on lines
+137
to
+144
| * 自然言語でのループ部分の引き継ぎの説明 | ||
| * x^(2^k)を計算します | ||
| * nの2^kに対応するbitが0 | ||
| * 自分の役目は終了 | ||
| * 次に見るべきbitを引き継ぐ | ||
| * nの2^kに対応するbitが1 | ||
| * 結果に対してx^(2^k)をかける | ||
| * 次に見るべきbitを引き継ぐ |
|
指摘されていた箇所以外は気になりませんでした。全体的に読みやすかったです。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/powx-n/description/