Skip to content

fix: remove pdf extension from export filename #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andostronaut merged 1 commit into from
Jan 11, 2025
Merged

fix: remove pdf extension from export filename #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions mod_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,6 @@ Deno.test(
},
)

Deno.test(
'generateFileName should return correct filename for pdf type',
() => {
const timestamp = /^prefix_\d{4}-\d{2}-\d{2}_\d{2}-\d{2}-\d{2}\.pdf$/
assert.assert(generateFileName('prefix', 'pdf').match(timestamp))
},
)

Deno.test('generateFileName should handle empty prefix', () => {
const tm = getTimestamp({ type: 'log' })
assert.assertEquals(generateFileName('', 'log'), `_${tm}.log`)
Expand Down
2 changes: 1 addition & 1 deletion src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const getTimestamp = ({ type = 'log' }: { type: 'log' | 'pdf' }): string => {
: `${year}-${month}-${day}_${hours}-${minutes}-${seconds}`
}

const generateFileName = (prefix: string, ext: 'log' | 'pdf'): string => {
const generateFileName = (prefix: string, ext: 'log'): string => {
const timestamp = getTimestamp({ type: ext })
return `${prefix}_${timestamp}.${ext}`
}
Expand Down
Loading