fix: improve error handling in requestAuthorization #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Re-throw errors from requestAuthorization instead of silently catching them - Throw proper error for iOS < 16.0 instead of just logging - Remove console.error to allow proper error handling by callers This allows applications to properly handle authorization failures and provide appropriate user feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
Previously,
requestAuthorizationwould silently catch and log errors, making it impossible for applications to handle authorization failures properly. This change allows callers to catch and handle errors appropriately, providingbetter user feedback.
This allows applications to properly handle authorization failures and provide appropriate user feedback.