Skip to content

Kaui 5.27#609

Open
tungleduyxyz wants to merge 4 commits into
masterfrom
kaui_5.27
Open

Kaui 5.27#609
tungleduyxyz wants to merge 4 commits into
masterfrom
kaui_5.27

Conversation

@tungleduyxyz
Copy link
Copy Markdown
Contributor

Related issues:

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces KAUI 5.27 UI/navigation updates to make the tenant Catalog accessible from the Settings sidebar (instead of the tenant show tabs) and adds a JSON download capability to the Queues page, aligning with issues #556 and technical-support #147.

Changes:

  • Added a dedicated /admin_tenants/:id/catalog route + AdminTenantsController#catalog action and a new catalog page view.
  • Moved Catalog access into the Settings sidebar and removed the Catalog tab/partial from the tenant settings show page.
  • Added a “Download JSON” button to the Queues page and updated catalog-related redirects/tests to target the new catalog page.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test/functional/kaui/admin_tenants_controller_test.rb Updates expectations to redirect to the new catalog page after catalog upload.
config/routes.rb Adds a new admin_tenant_catalog route for the dedicated catalog page.
app/views/kaui/queues/index.html.erb Adds “Download JSON” UI + client-side export logic for the active queues tab.
app/views/kaui/layouts/kaui_setting_sidebar.html.erb Adds a “Catalog Show” entry to the Settings sidebar when a tenant is present in session.
app/views/kaui/admin_tenants/show.html.erb Removes the Catalog tab/partial from the tenant settings page and adjusts tab activation JS.
app/views/kaui/admin_tenants/catalog.html.erb New dedicated catalog page rendering the existing catalog partials.
app/controllers/kaui/admin_tenants_controller.rb Adds catalog action, changes default active tab, and redirects catalog actions to the new catalog page.
Comments suppressed due to low confidence (1)

app/views/kaui/admin_tenants/show.html.erb:144

  • The Catalog tab/partial was removed from this page, but AdminTenantsController#show still fetches catalog versions (@catalog_versions/@latest_version). This now appears unused on the show page and adds an extra Kill Bill API call on every tenant settings load; consider removing it from #show and only loading it in the new #catalog action.
        <div class="tab-content">
          <%= render :partial => 'show_overdue' %>
          <%= render :partial => 'form_invoice_template' %>
          <%= render :partial => 'form_invoice_translation' %>
          <%= render :partial => 'form_catalog_translation' %>

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread app/views/kaui/layouts/kaui_setting_sidebar.html.erb Outdated
Comment thread app/views/kaui/queues/index.html.erb
@tungleduyxyz tungleduyxyz force-pushed the kaui_5.27 branch 2 times, most recently from b67fde5 to 3b73984 Compare May 25, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants