Kaui 5.27#609
Open
tungleduyxyz wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces KAUI 5.27 UI/navigation updates to make the tenant Catalog accessible from the Settings sidebar (instead of the tenant show tabs) and adds a JSON download capability to the Queues page, aligning with issues #556 and technical-support #147.
Changes:
- Added a dedicated
/admin_tenants/:id/catalogroute +AdminTenantsController#catalogaction and a new catalog page view. - Moved Catalog access into the Settings sidebar and removed the Catalog tab/partial from the tenant settings show page.
- Added a “Download JSON” button to the Queues page and updated catalog-related redirects/tests to target the new catalog page.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/functional/kaui/admin_tenants_controller_test.rb | Updates expectations to redirect to the new catalog page after catalog upload. |
| config/routes.rb | Adds a new admin_tenant_catalog route for the dedicated catalog page. |
| app/views/kaui/queues/index.html.erb | Adds “Download JSON” UI + client-side export logic for the active queues tab. |
| app/views/kaui/layouts/kaui_setting_sidebar.html.erb | Adds a “Catalog Show” entry to the Settings sidebar when a tenant is present in session. |
| app/views/kaui/admin_tenants/show.html.erb | Removes the Catalog tab/partial from the tenant settings page and adjusts tab activation JS. |
| app/views/kaui/admin_tenants/catalog.html.erb | New dedicated catalog page rendering the existing catalog partials. |
| app/controllers/kaui/admin_tenants_controller.rb | Adds catalog action, changes default active tab, and redirects catalog actions to the new catalog page. |
Comments suppressed due to low confidence (1)
app/views/kaui/admin_tenants/show.html.erb:144
- The Catalog tab/partial was removed from this page, but AdminTenantsController#show still fetches catalog versions (@catalog_versions/@latest_version). This now appears unused on the show page and adds an extra Kill Bill API call on every tenant settings load; consider removing it from #show and only loading it in the new #catalog action.
<div class="tab-content">
<%= render :partial => 'show_overdue' %>
<%= render :partial => 'form_invoice_template' %>
<%= render :partial => 'form_invoice_translation' %>
<%= render :partial => 'form_catalog_translation' %>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b67fde5 to
3b73984
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues: