Open
Conversation
There was a problem hiding this comment.
Pull request overview
Removes the single-node assumption when retrieving plugin information so multi-node Kill Bill deployments can display plugin data correctly, and adjusts account search flows to better handle multiple matches.
Changes:
- Aggregate plugins across all nodes instead of using
nodes_info.first(helper + test). - Deduplicate running plugin names across nodes when building the configurable plugin list.
- Update account search/controllers to route users to the accounts list when a query yields multiple matches.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/functional/kaui/admin_tenants_controller_test.rb | Updates test helper to aggregate plugins across all nodes. |
| app/helpers/kaui/plugin_helper.rb | Aggregates plugin info across nodes and dedupes running plugins by name. |
| app/controllers/kaui/home_controller.rb | Changes account search behavior for multiple matches (but introduces correctness/perf concerns). |
| app/controllers/kaui/accounts_controller.rb | Changes index redirect logic for search results (but uses incorrect pagination metadata). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
223dbb3 to
b1bd243
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.