fix SQL generation issues and add comprehensive tests #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
kholdrex
commented
Jan 6, 2026
kholdrex
commented
- Add GROUP BY support in string builder compilation path
- Implement HAVING clause support for both Arel and string builder
- Add validation to prevent empty array IN clauses (syntax error)
- Add comprehensive tests for compiler, validator, runner, explain_gate
- Fix query_spec tests for safe? and binds methods
kholdrex
force-pushed
the
fix/sql-generation-issues
branch
2 times, most recently
from
33c17f7 to
ed1d0b9
Compare
- Add GROUP BY support in string builder compilation path - Implement HAVING clause support for both Arel and string builder - Add validation to prevent empty array IN clauses (syntax error) - Add comprehensive tests for compiler, validator, runner, explain_gate - Fix query_spec tests for safe? and binds methods
kholdrex
force-pushed
the
fix/sql-generation-issues
branch
from
ed1d0b9 to
15921d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.