fix(web): block use of predictable "fallback" result to cases where no corrections could be found 🚂#15911
Open
jahorton wants to merge 2 commits into
Conversation
…o corrections could be found Build-bot: skip build:web Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
Bot
changed the title
ermshiperete
approved these changes
May 8, 2026
Comment on lines
280
to
281
Contributor
There was a problem hiding this comment.
Suggested change
| const correctionIsThePredictable = correctableToUpdate == this._predictable; | |
| const delistCorrectable = () => { | |
| if(!correctionIsThePredictable) { |
| } | ||
| } | ||
|
|
||
| const correctionIsThePredictable = correctableToUpdate == this._predictable; |
Contributor
There was a problem hiding this comment.
If we move this line a few lines higher then we can use it already for delistCorrectable.
Suggested change
| const correctionIsThePredictable = correctableToUpdate == this._predictable; |
| } | ||
|
|
||
| // We can make no further predictions if we've exhausted all search options. | ||
| if(correctableToUpdate == this._predictable) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if(correctableToUpdate == this._predictable) { | |
| if(correctionIsThePredictable) { |
ermshiperete
requested changes
May 11, 2026
| const correctionIsThePredictable = correctableToUpdate == this._predictable; | ||
| const delistCorrectable = () => { | ||
| if(correctableToUpdate != this._predictable) { | ||
| if(correctionIsThePredictable) { |
Contributor
There was a problem hiding this comment.
This is now the opposite. Should be:
Suggested change
| if(correctionIsThePredictable) { | |
| if(!correctionIsThePredictable) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build-bot: skip build:web
Test-bot: skip