chore: khmer translation now uses busra font#752
Open
Meng-Heng wants to merge 1 commit into
Open
Conversation
User Test ResultsTest specification and instructions User tests are not required |
darcywong00
reviewed
May 22, 2026
Comment on lines
+268
to
+273
| /* Khmer */ | ||
| :lang(km) { | ||
| /* The browser will automatically use Busra for Khmer chars and Cabin or Sans-serif for others */ | ||
| font-family: 'Busra','Cabin', sans-serif; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
-
For maintainability, can we move this alphabetically before Lao (line 289)?
-
I don't know CSS. Are Cabin and sans-serif already handled in line 173? (I note the other languages only reference one font for family, and not in quotes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR calls Busra font for Khmer translation (with Unicode range) on the website. Changing to this font allow easy skim reading, clearer and bolder characters, and readability. Please review.
Test-bot: skip
User Interfaces
URL: http://keyman.com.localhost:8053/km/keyboards/
URL: http://keyman.com.localhost:8053/km/downloads/
