feat: support lang parameter for keyboards embedded search#750
Merged
Conversation
User Test ResultsTest specification and instructions User tests are not required |
darcywong00
reviewed
May 20, 2026
|
|
||
| if(!isset($_SESSION['lang'])) { | ||
| $_SESSION['lang'] = isset($_REQUEST['lang']) ? $_REQUEST['lang'] : 'en'; | ||
| } |
Contributor
There was a problem hiding this comment.
What about the case where $_SESSION['lang'] is already set (fr)
and a different $_REQUEST['lang'] (de) comes in?
going from (appears in French)
http://keyman.com.localhost/fr/keyboards/?embed=none
to
http://keyman.com.localhost/go/android/14.0/download-keyboards?lang=de
appears in English
Member
Author
There was a problem hiding this comment.
That can't happen in the embed mode, because it will be a new session if the dialog is re-opened.
darcywong00
reviewed
May 20, 2026
| /** | ||
| * Set the current locales, with an array of fallbacks, ending in 'en'. | ||
| * @param $locale - the new current locale (xx-YY as specified in crowdin %locale%) | ||
| */ |
Contributor
There was a problem hiding this comment.
Can add a @param $fallback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-bot: skip
Relates-to: keymanapp/keyman#15948