feat: Start localizing Keyman product downloads page 🌋#749
Merged
Conversation
User Test ResultsTest specification and instructions User tests are not required |
Member
What is the dependency here? |
mcdurdin
approved these changes
May 20, 2026
Contributor
Author
|
my bad. that was copy-pasta from the original PR. Session refactored out with Locale.php handling it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-implements #688 with the new url-scheme. Fixes #687
This starts localizing the main Keyman products download page. Currently only has Spanish strings as provided by @philleckrone
Notes:
atm, locacalized pages depend on keyboards/Session.php so wee may need to (separately) refactor that to a common folderScreenshot
http://keyman.com.localhost/es/downloads/
Test-bot: skip