chore: Move composer.json test scripts to build.sh test #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcywong00
force-pushed
the
chore/clean-composer-scripts
branch
3 times, most recently
from
dd97a69 to
7ed781d
Compare
darcywong00
force-pushed
the
chore/clean-composer-scripts
branch
from
7ed781d to
187c116
Compare
User Test ResultsTest specification and instructions User tests are not required |
darcywong00
force-pushed
the
chore/clean-composer-scripts
branch
3 times, most recently
from
13cdf04 to
6d2e338
Compare
* Add PHP unit test step * Configure Docker image to install phpunit when BUILDER_CONFIGURATION=debug
darcywong00
force-pushed
the
chore/clean-composer-scripts
branch
from
6d2e338 to
6206dc8
Compare
darcywong00
commented
Nov 26, 2025
| builder_run_action clean clean_docker_container $KEYMAN_IMAGE_NAME $KEYMAN_CONTAINER_NAME | ||
| builder_run_action stop stop_docker_container $KEYMAN_IMAGE_NAME $KEYMAN_CONTAINER_NAME | ||
| builder_run_action build build_docker_container $KEYMAN_IMAGE_NAME $KEYMAN_CONTAINER_NAME | ||
| builder_run_action build build_docker_container $KEYMAN_IMAGE_NAME $KEYMAN_CONTAINER_NAME $BUILDER_CONFIGURATION |
Contributor
Author
There was a problem hiding this comment.
This passes in the BUILDER_CONFIGURATION parameter for keymanapp/shared-sites#84
darcywong00
commented
Nov 26, 2025
| { | ||
| $this->assertTrue(true); | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
copied from help.keyman.com
Contributor
Author
There was a problem hiding this comment.
Should .htaccess block the /tests folder? Otherwise, I get this error
Fatal error: Uncaught Error: Class 'PHPUnit\Framework\TestCase' not found in /var/www/html/tests/InfrastructureTest.php:7 Stack trace: #0 {main} thrown in /var/www/html/tests/InfrastructureTest.php on line 7
darcywong00
changed the title
darcywong00
commented
Nov 26, 2025
| run: | | ||
| echo "TIER_TEST" > tier.txt | ||
| ./build.sh build start | ||
| ./build.sh configure build start --debug |
Contributor
Author
There was a problem hiding this comment.
--debug needed so Docker will build with dev dependencies
mcdurdin
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #493
Moving scripts for tests from composer.json into ci.yml and
build.sh testTesting involves:
This involves passing
build.sh build --debugparameter so thecomposer installstep installs dev dependencies.Test-bot: skip