fix variable/method names in avdl

[songgao]

No description provided.

[songgao]

r? @mmaxim @gabriel

[maxtaco]

This change is going to be very challenging to roll out without breaking
chat. All legacy clients will have failures.

On Tue, Nov 22, 2016 at 10:40 AM Mike Maxim notifications@github.com
wrote:

@mmaxim approved this pull request.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#4926 (review),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA05_8pKpP4OLejEXxUcjpZnDXP9_T3Mks5rAwlGgaJpZM4K44lC
.

[songgao]

Is it because of the codec name changes? Names in Go code doesn't change at all.

[maxtaco]

Wire representation is different and you are going to have rpc procedure
not found errors.

On Tue, Nov 22, 2016 at 11:24 AM Song Gao notifications@github.com wrote:

Is it because of the codec name changes? Names in Go code doesn't change
at all.

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#4926 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA05_5CjZlT66O2uHWv517RY6JJlv0Wwks5rAxdJgaJpZM4K44lC
.

[songgao]

I see. So shall we drop this for now then?

[songgao]

Although on the other hand we haven't released chat yet ...

[maxtaco]

If it matters then it should be done now but everything will break when it
goes in.

Once chat is live we never can make breaking changes like this one.

On Tue, Nov 22, 2016 at 7:55 PM Song Gao notifications@github.com wrote:

Although on the other hand we haven't released chat yet ...

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#4926 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA05_0W4vcKXmH45h3Xt4SIBruHZnNgHks5rA48GgaJpZM4K44lC
.

[songgao]

closing in favor of #5004

[gabriel]

We could do it Monday when everyone is together? If not, we're stuck with it forever :(

[songgao]

Yeah; sounds good!

[patrickxb]

To be clear, there are users using chat outside the company even though it hasn't been released. This will likely cause them issues.

[songgao]

Yeah but it's not even released, and this is the same level of break that we've done in the past for chat since the soft launch. If we ever want the name fixed, now is a better time tha later unless we count on a V2 in the future.

[maxtaco]

@malgorithms says it's OK to break chat at the moment...