initial beta expo 56#29204
Open
chrisnojima wants to merge 2 commits intonojima/HOTPOT-next-670-clean-2from
Open
initial beta expo 56#29204chrisnojima wants to merge 2 commits intonojima/HOTPOT-next-670-clean-2from
chrisnojima wants to merge 2 commits intonojima/HOTPOT-next-670-clean-2from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-[ ] native tab bar totally broken. no icons and switching crashes
Blocker: @react-navigation/bottom-tabs incompatible with react-native-screens@4.25.0-beta.3
Expo 56 beta pins react-native-screens@4.25.0-beta.3 (via bundledNativeModules.json), which introduced two breaking API changes
to Tabs.Screen that @react-navigation/bottom-tabs@7.15.12 (current latest) has not been updated for:
press: RCTAssert(screenKey != nil, @"[RNScreens] screenKey MUST NOT be nil")
reads them only from the nested ios.* namespace → tab bar icons missing on iOS (labels still show).
The next-tagged version of bottom-tabs is 8.0.0-alpha.26, which would require upgrading all of react-navigation to v8.
Unblocked by: a @react-navigation/bottom-tabs@7.x patch release supporting the new rn-screens API, or a stable
react-native-screens@4.25.0 that react-navigation v7 ships against.