-
Notifications
You must be signed in to change notification settings - Fork 6
fix(jsonata): prevent StackOverflowError on small JVM stacks via eval thread isolation + lower default maxDepth #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fdelbrayelle
wants to merge
11
commits into
main
Choose a base branch
from
test/stack-overflow-regression
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a55b948
test(jsonata): add StackOverflow regression tests for small JVM stacks
fdelbrayelle 654e141
test(jsonata): refine StackOverflow regression tests — shared 256k st…
fdelbrayelle 7faddb8
test(jsonata): assert StackOverflowError and name constant XSS_256K
fdelbrayelle 0195a62
test(jsonata): use -Xss256k JVM flag instead of Thread(stackSize)
fdelbrayelle debcfee
test(jsonata): fix -Xss256k not applied — root build used jvmArgs= (r…
fdelbrayelle dd35c34
test(jsonata): drop -Xss256k, increase depth to crash default Linux s…
fdelbrayelle ddea75c
test(jsonata): use -Xss512k + depth=49999 to guarantee stack overflow…
fdelbrayelle 681cfa7
test(jsonata): fix expression — use non-tail-recursive form to preven…
fdelbrayelle 8ed5a14
test(jsonata): revert to assertThatThrownBy — lib not upgraded yet
fdelbrayelle 201b280
fix(jsonata): isolate eval on 4MB thread + lower default maxDepth to 50
fdelbrayelle f94dd17
refactor(jsonata): replace per-call Thread with per-instance executor…
fdelbrayelle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.