Fix packaging#68
Merged
Merged
Conversation
flit_core 4 dropped support for [tool.flit.metadata]. The Arch CI image was rebuilt with flit_core 4, so `flit build` fails. Move the metadata to the [project] table. Read version and description from tuxrun/__init__.py as dynamic fields. Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
bhcopeland
reviewed
May 22, 2026
| [project] | ||
| name = "tuxrun" | ||
| authors = [ | ||
| {name = "Antonio Terceiro", email = "antonio.terceiro@linaro.org"}, |
Collaborator
Author
There was a problem hiding this comment.
I did that in the followup commit
Member
There was a problem hiding this comment.
I see but it gets added here 7101a66. What threw me, cool =)
ivoire
reviewed
May 26, 2026
|
|
||
| [tool.flit.scripts] | ||
| [project.urls] | ||
| Homepage = "https://tuxsuite.com/" |
Contributor
There was a problem hiding this comment.
Should be https://tuxrun.org instead? (was already wrong before this PR).
The original author no longer works at Linaro and the antonio.terceiro@linaro.org address bounces. Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
flit-core 4.0 dropped the implicit "include VCS files" behavior. The sdist now only contains the tuxrun package. The Arch PKGBUILD check() step runs pytest there, finds no tests and fails. Add test/ to [tool.flit.sdist] so the sdist always ships the unit tests. Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
ivoire
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.