Skip to content

fix: use single columns on smaller screens #1802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gustavobtflores merged 1 commit into from
Mar 24, 2026
Merged

fix: use single columns on smaller screens #1802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dashboard/src/components/BuildDetails/BuildDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ const BuildDetails = ({
infos: [
{
children: (
<div className="grid grid-cols-2 gap-4">
<div className="grid grid-cols-1 gap-4 lg:grid-cols-2">
Copy link
Copy Markdown
Contributor

@alanpeixinho alanpeixinho Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When going single column the cards are overflowing the screen size.
Take a double look on the cards size.

before after
Image Image

Copy link
Copy Markdown
Contributor Author

@dede999 dede999 Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see this problem unless I switch pages on viewport inspection mode; in this case, I disable and re-enable it, and the problem is gone

<DetailsInfoCard
cardTitle="buildDetails.buildInfo"
data={[
Expand Down
6 changes: 4 additions & 2 deletions dashboard/src/components/Section/Section.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,11 @@ export const Subsection = ({ infos, title }: ISubsection): JSX.Element => {
<div className="border-dark-gray border-t pt-4">
{title && <span className="text-xl">{title}</span>}
{items.length > 0 && (
<div className="grid grid-cols-2 gap-x-8 gap-y-11 pb-4">{items}</div>
<div className="grid grid-cols-1 gap-x-8 gap-y-11 pb-4 md:grid-cols-2">
{items}
</div>
)}
{children.length > 0 && <div className="mb-4 w-[80vw]">{children}</div>}
{children.length > 0 && <div className="mb-4">{children}</div>}
</div>
);
};
Expand Down
2 changes: 1 addition & 1 deletion dashboard/src/components/TestDetails/TestDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ const TestDetailsSections = ({
infos: [
{
children: (
<div className="grid grid-cols-2 gap-4">
<div className="grid grid-cols-1 gap-4 lg:grid-cols-2">
<DetailsInfoCard
cardTitle="testDetails.testInfo"
data={[
Expand Down
Loading