[kernel-1116] browser logging: cdp monitor#195
Draft
archandatta wants to merge 27 commits intoarchand/kernel-1116/cdp-pipelinefrom
Draft
[kernel-1116] browser logging: cdp monitor#195archandatta wants to merge 27 commits intoarchand/kernel-1116/cdp-pipelinefrom
archandatta wants to merge 27 commits intoarchand/kernel-1116/cdp-pipelinefrom
Conversation
…ader godoc, and test correctness
… add concurrent publish+read race test
Event is the agreed portable name. DetailStandard avoids Go keyword ambiguity with "default".
Moves CDP-specific fields (target_id, cdp_session_id, frame_id, parent_frame_id) under source.metadata. Top-level Event schema now contains only stable cross-producer fields.
…ut of Event Event is now purely producer-emitted content. Pipeline-assigned metadata (seq, capture_session_id) lives on the Envelope. truncateIfNeeded operates on the full Envelope. Pipeline type comment now documents lifecycle semantics.
Ring buffer now indexes by envelope.Seq directly, removing the separate head/written counters. NewReader takes an explicit afterSeq for resume support. Renamed notify to readerWake for clarity.
Drops are now stream metadata (ReadResult.Dropped) rather than fake events smuggled into the Event schema. Transport layer decides how to surface gaps on the wire.
truncateIfNeeded now warns if the envelope still exceeds the 1MB limit after nulling data (e.g. huge url or source.metadata). Pipeline.Publish skips the file write when marshal returns nil to avoid writing corrupt bare-newline JSONL lines.
archandatta
force-pushed
the
archand/kernel-1116/cdp-pipeline
branch
2 times, most recently
from
6d929c8 to
76d837f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.