-
Notifications
You must be signed in to change notification settings - Fork 1
feat: migrate config system from dotenv to koanf/YAML #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
ba833a0
feat: migrate config system from dotenv to koanf/YAML
rgarcia 9404fc0
fix: address bot review feedback on config loading
rgarcia 0d2d9d1
fix: skip empty env vars to preserve config/default values
rgarcia 6d45ed0
fix: gen-jwt respects CONFIG_PATH, install.sh uses sudo for config read
rgarcia f34c532
fix: robust YAML parsing in install.sh and restore make gen-jwt dev w…
rgarcia 130962f
refactor: use __ delimiter for nested env vars, rename example files
rgarcia c44e260
docs: simplify config docs to reference YAML keys, not env vars
rgarcia 0daee7c
chore: default build.builder_image to "none" (built on first run)
rgarcia ef97848
fix: BSD sed compat for docker_socket injection in install.sh
rgarcia a6e82a5
fix: export CLI env vars in e2e test for released CLI compat
rgarcia dc89274
Revert "fix: export CLI env vars in e2e test for released CLI compat"
rgarcia c401e3b
feat: support CLI_BRANCH to build CLI from source in install.sh
rgarcia 8f26e4c
fix: update GPU test files to use nested config struct
rgarcia 1cfd871
fix: remove fallback config generation from install.sh
rgarcia 784382d
cleanup: remove redundant OS check inside darwin block
rgarcia 25494cc
fix: hard error if jwt_secret not found in config template
rgarcia 3760223
fix: remove accidentally committed gen-jwt binary
rgarcia 673f652
docs: remove token tool row from config table
rgarcia f00f60b
refactor: remove dead fallbacks and "none" sentinel for builder_image
rgarcia 304493e
fix: validate build.timeout and build.max_concurrent_source_builds
rgarcia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -112,7 +112,7 @@ jobs: | |
| - name: Install dependencies | ||
| run: brew list caddy &>/dev/null || brew install caddy | ||
| - name: Run E2E install test | ||
| run: bash scripts/e2e-install-test.sh | ||
| run: CLI_BRANCH=koanf-yaml-config bash scripts/e2e-install-test.sh | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. todo: revert after CLI PR is merged / deployed |
||
| - name: Cleanup on failure | ||
| if: failure() | ||
| run: bash scripts/uninstall.sh || true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # ============================================================================= | ||
| # Hypeman CLI Configuration | ||
| # ============================================================================= | ||
| # Place this file at ~/.config/hypeman/cli.yaml | ||
| # | ||
| # The install script automatically generates this file with a valid token | ||
| # for local access. For remote CLI access, create this file manually. | ||
| # | ||
| # Configuration precedence (highest to lowest): | ||
| # 1. CLI flags (e.g., --base-url) | ||
| # 2. Environment variables (HYPEMAN_BASE_URL, HYPEMAN_API_KEY) | ||
| # 3. This YAML config file | ||
| # ============================================================================= | ||
|
|
||
| # Hypeman API URL | ||
| base_url: http://localhost:8080 | ||
|
|
||
| # API authentication token (generated by hypeman-token) | ||
| api_key: "" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI hardcodes temporary CLI branch name
High Severity
The e2e install test hardcodes
CLI_BRANCH=koanf-yaml-config, referencing a development branch in the companion CLI repository. Once this PR and the companion CLI PR are merged and thekoanf-yaml-configbranch is deleted, thegit clone --branchininstall.shwill fail, breaking the CI e2e install test on every subsequent run.