Commit ec3174e
committed
fastapi-sqlalchemy-pg-catalog: parameterize README + SQL_ECHO env knob
Addresses two Copilot review nits on #102:
* README.md: the local-repro snippet hardcoded
`--container-name pg-catalog-repro-app`, but the compose file uses
`${APP_CONTAINER:-pg-catalog-repro-app}` so a user who overrides
APP_CONTAINER (e.g. to isolate concurrent runs) would have keploy
point at a non-existent container. Both keploy invocations now
thread `${APP_CONTAINER:-pg-catalog-repro-app}` so they pick up
the same env override compose sees. Also switched the deprecated
camelCase `--apiTimeout`/`--disableMockUpload` to the kebab forms
the v3 CLI actually registers (`--api-timeout`; mock-upload flag
dropped — not registered on v3-dev `test`).
* main.py: SQL echo was unconditional. It is INTENTIONALLY on by
default for this sample (the whole point is to surface SQLAlchemy's
pg_class probe + create_all behaviour in the app log so a reader
can correlate it with the keploy agent log), but the noise is real
for unrelated investigations. Gated behind SQL_ECHO env var with a
comment explaining why it's on by default.
Signed-off-by: Akash Kumar <meakash7902@gmail.com>1 parent 4becdde commit ec3174e
2 files changed
Lines changed: 17 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
46 | 50 | | |
47 | 51 | | |
48 | 52 | | |
49 | | - | |
| 53 | + | |
50 | 54 | | |
51 | 55 | | |
52 | 56 | | |
53 | 57 | | |
54 | 58 | | |
55 | 59 | | |
56 | | - | |
| 60 | + | |
57 | 61 | | |
58 | | - | |
| 62 | + | |
59 | 63 | | |
60 | 64 | | |
61 | 65 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
36 | 45 | | |
37 | 46 | | |
38 | 47 | | |
| |||
44 | 53 | | |
45 | 54 | | |
46 | 55 | | |
47 | | - | |
| 56 | + | |
48 | 57 | | |
49 | 58 | | |
50 | 59 | | |
| |||
0 commit comments