fastapi-sqlalchemy-pg-catalog: tighten flow.sh + init.sql per Copilot review

flow.sh:
- set -Eeuo pipefail so curl/other failures actually fail the script.
- Track readiness explicitly; exit 1 with a clear message if the app
  never reaches /health within READY_TIMEOUT_S (default 60s) instead
  of silently falling through and proceeding against a dead app.
- curl -fsS for the readiness probe and the endpoint calls so HTTP
  failures propagate as exit codes (the previous `curl -sS ... && echo`
  shape silenced non-2xx responses).

init.sql:
- Replace `INSERT ... ON CONFLICT DO NOTHING` with `INSERT ... SELECT
  WHERE NOT EXISTS`. The model has no UNIQUE constraint on name, so
  ON CONFLICT had nothing to fire on; this form is genuinely idempotent
  on re-runs against an existing volume.

Refs Copilot review on #102.

Signed-off-by: Akash Kumar <meakash7902@gmail.com>

Author: AkashKumar7902

fastapi-sqlalchemy-pg-catalog/flow.sh

@@ -1,23 +1,33 @@
 #!/usr/bin/env bash
 # Drives traffic during keploy record. Hits both endpoints.
-set -uo pipefail
+set -Eeuo pipefail
 
 APP_HOST_PORT="${APP_HOST_PORT:-8123}"
 APP_URL="${APP_URL:-http://localhost:${APP_HOST_PORT}}"
+READY_TIMEOUT_S="${READY_TIMEOUT_S:-60}"
 
-echo "[flow] waiting for app at $APP_URL ..."
-for i in $(seq 1 60); do
-  if curl -sf "$APP_URL/health" > /dev/null 2>&1; then
+echo "[flow] waiting for app at $APP_URL (ceiling ${READY_TIMEOUT_S}s) ..."
+ready=0
+for i in $(seq 1 "$READY_TIMEOUT_S"); do
+  if curl -fsS --max-time 1 "$APP_URL/health" > /dev/null 2>&1; then
     echo "[flow] app ready after ${i}s"
+    ready=1
     break
   fi
   sleep 1
 done
 
+if [ "$ready" -ne 1 ]; then
+  echo "[flow] ERROR: app never became ready at $APP_URL/health within ${READY_TIMEOUT_S}s" >&2
+  exit 1
+fi
+
 echo "[flow] GET /health"
-curl -sS "$APP_URL/health" && echo
+curl -fsS "$APP_URL/health"
+echo
 
 echo "[flow] GET /projects"
-curl -sS "$APP_URL/projects" && echo
+curl -fsS "$APP_URL/projects"
+echo
 
 echo "[flow] done"

fastapi-sqlalchemy-pg-catalog/init.sql

@@ -12,4 +12,10 @@ CREATE TABLE IF NOT EXISTS project (
     name VARCHAR(100) NOT NULL
 );
 
-INSERT INTO project (name) VALUES ('seed') ON CONFLICT DO NOTHING;
+-- Idempotent seed. `ON CONFLICT DO NOTHING` would only help with a
+-- UNIQUE/EXCLUSION constraint on name, which the SQLAlchemy model
+-- doesn't declare; use NOT EXISTS so re-running this script against
+-- an existing volume doesn't duplicate the row.
+INSERT INTO project (name)
+SELECT 'seed'
+WHERE NOT EXISTS (SELECT 1 FROM project WHERE name = 'seed');