Open
Conversation
instructions.js
Outdated
| return COLOR_ABBR[id] || (typeof id === 'string' ? id.slice(0, 2).toUpperCase() : '??'); | ||
| } | ||
|
|
||
| function rle(arr) { |
There was a problem hiding this comment.
What does this function do? This function name does not seem to explain well what it is accomplishing.
There was a problem hiding this comment.
This server entry point file is done very well. Organized well and is very easy to read. good job!
instructions.js
Outdated
There was a problem hiding this comment.
This file was quite difficult to understand. Some clarifying comments would have been nice.
instructions.js
Outdated
| const m = /^rgb\((\d+),\s*(\d+),\s*(\d+)\)$/.exec(rgb); | ||
| if (!m) return rgb; // already hex or unknown format | ||
| const h = n => Number(n).toString(16).padStart(2, '0'); | ||
| return `#${h(m[1])}${h(m[2])}${h(m[3])}`; |
Contributor
There was a problem hiding this comment.
What does this do? Lack of comments, very confusing to understand
| queueLimit: 0, | ||
| }); | ||
|
|
||
| export default pool; |
Contributor
There was a problem hiding this comment.
Love the simplicity of the db
Contributor
AlexanderORuban
left a comment
AlexanderORuban
left a comment
There was a problem hiding this comment.
- Break up app.js to use routers and controllers for better organization
- instructions.js is confusing due to a lack of comments
- Variable names could be longer to give more context
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.