Conversation
Owner
|
I think |
Contributor
Author
|
lets go with saveoffset then, I think it'll work |
Owner
|
Ok, merging |
Owner
|
@Toxicable I realized the documentation uses saveOffset. Do you wanna go with saveOffset or saveoffset? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based off this MR for the most part: #89
This allows for saving the current internal offset to a variable returned to the user.
My use case for this is checking that the offset at the end of a dynamic read matches the length of the input buffer.
Taking suggestions on the name of this, im not sold on
saveoffset