fix(api): remove invalid joinedload on Incident.alerts property#6518
Open
hermes18974-jpg wants to merge 1 commit into
Open
fix(api): remove invalid joinedload on Incident.alerts property#6518hermes18974-jpg wants to merge 1 commit into
hermes18974-jpg wants to merge 1 commit into
Conversation
used , but is a Python @Property backed by a PrivateAttr, not an ORM relationship. SQLModel/SQLAlchemy raised: Expected ORM mapped instance attribute, got: <property object> This caused POST /v2/incidents/{id}/confirm to return 500 when confirming predicted incidents that have associated alerts. Removing the eager-load option lets the property resolve naturally from the already-loaded incident instance. Fixes keephq#6507
dosubot
Bot
added
size:XS
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
confirm_predicted_incident_by_id()usedjoinedload(Incident.alerts), butalertsis a Python@propertybacked by a_alertsPrivateAttr, not an ORM relationship.SQLModel/SQLAlchemy raised:
This caused
POST /v2/incidents/{id}/confirmto return 500 when confirming predicted incidents that have associated alerts.Changes
.options(joinedload(Incident.alerts))call fromconfirm_predicted_incident_by_id()inkeep/api/core/db.py.alertsproperty already reads from_alertswhich is populated elsewhere; eager-loading it via SQL is unnecessary and incorrect.Fixes
Fixes #6507
Checklist