fix: ServiceNow _notify_update now uses PATCH to actually update tickets#6177
Open
DragonBot00 wants to merge 1 commit intokeephq:mainfrom
Open
fix: ServiceNow _notify_update now uses PATCH to actually update tickets#6177DragonBot00 wants to merge 1 commit intokeephq:mainfrom
DragonBot00 wants to merge 1 commit intokeephq:mainfrom
Conversation
|
@DragonBot00 is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two related ServiceNow provider bugs in
_notify_update:requests.get— it fetched the ticket but never modified it. Should berequests.patch.if self._access_tokenwas used whereif not self._access_tokenwas needed, causing 401 errors when using token auth.Also fixed a typo:
resp.raise_for_status()→response.raise_for_status().Closes #4949
Closes #4948
Changes
requests.getwithrequests.patchin_notify_updateif self._access_token→if not self._access_tokenpayload: dict = {}parameter so callers can pass update fields_notifyto forwardpayload+ remainingkwargsas the update bodyUsage example