feat: add custom payload support to Grafana OnCall provider#6176
Open
DragonBot00 wants to merge 1 commit intokeephq:mainfrom
Open
feat: add custom payload support to Grafana OnCall provider#6176DragonBot00 wants to merge 1 commit intokeephq:mainfrom
DragonBot00 wants to merge 1 commit intokeephq:mainfrom
Conversation
|
@DragonBot00 is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
payloadparameter to the Grafana OnCall provider's_notifymethod, allowing users to send a fully custom JSON body to the OnCall webhook instead of the default structured payload.Motivation
The Grafana OnCall webhook accepts arbitrary key-value pairs for custom templating, but the provider was limited to a fixed set of fields (
title,message,alert_uid,image_url,state,link_to_upstream_details). This prevented users from leveraging OnCall's full templating capabilities.Closes #5316
Changes
payload: dict | None = Noneparameter to_notifypayloadis provided, it is sent directly to the webhook — giving full control over the request bodypayloadisNone(default), the existing structured body is used — fully backwards compatible__init__definition in the original file (two__init__methods were defined)Usage example
Testing
payloadargument) remains unchangedpayloadis passed, it is forwarded directly without modification