Enable footer countdown banner message localization#253
Open
oliveiraleo wants to merge 5 commits intokeepandroidopen:mainfrom
Open
Enable footer countdown banner message localization#253oliveiraleo wants to merge 5 commits intokeepandroidopen:mainfrom
oliveiraleo wants to merge 5 commits intokeepandroidopen:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This PR adds the
banner_footer_messagevar to make the banner message in the footer localized. The pt-BR and es translations for the message are also added with some extra minor fixes. The screenshots below show how the modifications suggested will appear in the website.If the message isn't localized, the English version will be used by default (similarly to the other vars). In case I've missed something in the configuration, please reach out to me.
Screenshot demos
Original message (en)
pt-BR
es
TIA for reviewing this PR,
Leo.