feat: Add theme support to CannyChangelog #10
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add theme support to CannyChangelog component
Issue
The
CannyChangelogcomponent doesn't support thethemeprop, even though Canny's SDK supportstheme: 'light' | 'dark' | 'auto'. This forces the widget to always render in light mode, breaking dark mode support in apps.Solution
Add
themetoChangeLogOptionstype and pass it through in theCannyChangelogcomponent.Changes
src/makes/Canny.ts: Addtheme?: "auto" | "light" | "dark"toChangeLogOptionssrc/views/CannyChangelog/index.tsx: Extract and passthemeprop toinitChangelog()Usage
Fully backward compatible -
themeis optional and defaults to existing behavior.@kearisp Thanks for this package 🙂