New Dao module #27
Merged
New Dao module #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace explicit SQLDelight plugin declaration with a BOM-aligned alias. - Introduce SQL schema definitions for `applications`, `developers`, `app_categories`, and `google_play_categories`. - Configure SQLDelight in `store` module and add SQLite driver dependency. - Update build scripts and `libs.versions.toml` to include SQLDelight setup.
…ore` generator module - Added SQLDelight schema definition for `version` table. - Replaced manual JDBC-based database handling with SQLDelight APIs. - Refactored database initialization, category insertion, and app package processing to align with SQLDelight structure. - Updated `SqliteStoreBuilder` with new APIs and utility functions for streamlined database operations.
…parameterized `createSqlDriver` - Updated database methods (`insertCategories`, `insertVersion`, `upsertPackages`) to accept `outputDbPath` for dynamic driver creation. - Consolidated imports in `SqliteStoreBuilder`. - Simplified and aligned database queries with parameterized approach.
- Simplify assignments by removing unnecessary nullable-to-primitive conversions. - Enhance code readability and consistency in `store` generator module.
- Introduced `buildMultiLanguageDatabases` method to generate databases in English, French, and Hebrew. - Extended `buildDatabase` and `upsertPackages` to accept language and country parameters. - Updated `SqliteStoreExtractor` to utilize the multi-language database creation feature.
- Replaced French references with English equivalents for `developer_id` and `app_category_id` comments.
- Moved SQLDelight schemas (`applications.sq`, `developers.sq`, `app_categories.sq`, `google_play_categories.sq`, `version.sq`) to the new `dao` module. - Configured `dao` module with SQLDelight, Maven publishing, and Android compatibility. - Refactored `store` module to include `dao` as a dependency and remove redundant SQLDelight configuration. - Updated build scripts, including `settings.gradle.kts`, to include the `dao` module.
…omposeApp` - Deleted `sqldelight` plugin configuration and `Database` setup in `build.gradle.kts`. - Removed `DatabaseManager` and associated functions (`downloadLatestDatabaseIfNotExists`, `refreshDatabase`). - Refactored application logic to utilize separate `dao` and `localization` modules for database operations and app information. - Updated `SqlDriverFactory` implementations for both Android and JVM to adapt to the new modular database structure. - Deleted redundant database schema files (`Store.sq`, `PackageInfo.kt`).
…n of concerns - Introduced `AppRow`, `AppDetailDialog`, and `SearchScreen` as reusable UI components under `ui` package. - Added `AppInfoWithExtras` model in the `models` package to extend `GooglePlayApplicationInfo` with category details. - Created `DatabaseOperations` for centralized database operations including loading and searching applications. - Refactored `App` to support navigation between Home and Search screens using `NavigationBar`. - Implemented `ImageUtils` for consistent image loading utility with Coil.
…foWithExtras` - Deleted `categoryRawName` from the `AppInfoWithExtras` model as it is redundant. - Simplified category localization logic in `createAppInfoWithExtras` by removing fallback handling for non-existent enums.
- Migrated all database-related logic (`loadApplicationsFromDatabase`, `searchApplicationsInDatabase`) from `composeApp` to `dao`. - Removed `DatabaseOperations` and `AppModels` from `composeApp`. - Added `ApplicationsDao` in `dao` module to handle database operations with a generic creator pattern for flexibility. - Updated Gradle configurations to set `minSdk` to 24 and reorganized dependencies for the `dao` module. - Adapted `App.kt` and UI components to use `ApplicationsDao` and `AppInfoWithExtras` directly.
- Updated `release-sqlite-db.yml` to handle English, French, and Hebrew store database files during verification and release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.