Handle explicit undefined values #8
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In JSON, you can explicitly define a value as
undefined:When running the
formatfunction against the above object, the following error is observed:/Users/dean/projects/lua-json/index.js:53 throw new Error(`can't format ${typeof value}`) ^ Error: can't format undefined at rec (/Users/dean/projects/lua-json/index.js:53:11) at /Users/dean/projects/lua-json/index.js:46:79 at Array.map (<anonymous>) at rec (/Users/dean/projects/lua-json/index.js:46:12) at format (/Users/dean/projects/lua-json/index.js:56:47) at Object.<anonymous> (/Users/dean/projects/lua-json/test.js:70:7) at Module._compile (node:internal/modules/cjs/loader:1101:14) at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10) at Module.load (node:internal/modules/cjs/loader:981:32) at Function.Module._load (node:internal/modules/cjs/loader:822:12)This commit adds the missing safeguard against any explicit undefined values which prevents the fall through to
throw new Error('can't format ${typeof value}').Adding this surfaces a small issue wherein\n\nis written to the formatted string. As far as I can tell, this is due to the way the${eol}is prepended (rather than appended) to each line. There is a.replacemethod call to take care of the\n\n, however, this has a limit. For example,\n\n\nwould still become\n\n.Even accounting for the above double-line issue, this does fix the fatal error when dealing withundefinedvalues and still produces a valid Lua string.Edit: I solved the above with a simple
do...whileloop.A specific test case was added because the shape of the JSON and Lua are not interchangeable. For example: