Skip to content

restore kcp 0.28 tests#200

Open
xrstf wants to merge 4 commits intokcp-dev:mainfrom
xrstf:restore-kcp-versions
Open

restore kcp 0.28 tests#200
xrstf wants to merge 4 commits intokcp-dev:mainfrom
xrstf:restore-kcp-versions

Conversation

@xrstf
Copy link
Copy Markdown
Contributor

@xrstf xrstf commented Apr 8, 2026

Summary

These got lost in #188 and I see no reason why we should already stop testing against 0.28, a supported kcp release. With the current config, we effectively tested against kcp 0.30.1 and release-0.30.

The main difference is that kcp 0.28 doesn't have a release with support for authentication on the cache server, so the e2e tests fail. We already have some logic to kind of sort of detect the kcp release and skip certain tests, but the logic could not catch this particular case.

To make this more palatable, I reworked the concept a bit: The setup scripts for the e2e tests will now not just resolve the branch name (release-0.30 => 387ad6e), but also pull and re-tag the image, so 387ad6e becomes 0.30.999. The re-tagged image is then preloaded into kind. The old KCP_RELEASE hack was re-used to supply a suitable release for KCP_TAG=main, but is otherwise not used in the tests anymore.

To actually handle the version differences, I added parsing logic to the image tag in the operator. If the tag fails to parse, no worries, we'll just use it but assume you have the latest and greatest kcp. If you need to opt-in to a specific release's treatment by the operator, tag your custom images with a semver.

What Type of PR Is This?

/kind cleanup

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Apr 8, 2026
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 8, 2026
@xrstf
Copy link
Copy Markdown
Contributor Author

xrstf commented Apr 8, 2026

/cherrypick release-0.6

@kcp-ci-bot
Copy link
Copy Markdown
Contributor

@xrstf: once the present PR merges, I will cherry-pick it on top of release-0.6 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

xrstf added 3 commits April 8, 2026 20:42
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
…in tests much more readable

On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf xrstf force-pushed the restore-kcp-versions branch from 51d2b87 to 95137c4 Compare April 8, 2026 18:43
@kcp-ci-bot kcp-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 8, 2026
On-behalf-of: @SAP christoph.mewes@sap.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants